|
|
283eee687c
|
Fix Extended Thinking critical bug and optimize default parameters
CRITICAL BUG FIXED:
- max_tokens vs thinking_budget_tokens API constraint violation resolved
- Changed max_tokens from 4096 to 8192 (App.jsx:4747)
- Changed thinking_budget_tokens from 10000 to 6144 (App.jsx:4749)
- Updated database default from 10000 to 6144 (server/db/index.js:243)
- Result: 8192 > 6144 ✅ API constraint satisfied
FRONTEND FIX:
- Fixed SSE data mapping for thinking content (App.jsx:5565-5566)
- Changed from data.thinking_signature to data.thinking.signature
- Changed from fullThinking to data.thinking.content with fallback
- ThinkingBlock now displays and persists correctly after streaming
CONFIGURATION:
- Extended Thinking disabled by default (was true for testing)
- Optimal defaults: max_tokens=8192, thinking_budget=6144 (6K)
- User-tested configuration validates 6K thinking budget ideal
DATABASE UPDATES:
- Updated 10+ existing conversations to thinking_budget_tokens=4096
- New conversations default to 6144 tokens
- Thinking content now saves and persists correctly
TESTING:
- ✅ Manual test with Whitehead philosophy question successful
- ✅ ThinkingBlock displays with blue UI and brain icon
- ✅ Expand/collapse functionality works
- ✅ Signature verification indicator shows
- ✅ Content persists after streaming and page reload
ISSUES COMPLETED:
- TEAMPHI-194: ThinkingBlock Component (validated)
- TEAMPHI-195: ThinkingBlock Integration (fully functional)
- TEAMPHI-199: Streaming Handler (data mapping fixed)
Progress: 60% → 80% complete
Files modified:
- generations/my_project/src/App.jsx (lines 4747-4749, 5565-5566)
- generations/my_project/server/db/index.js (line 243)
- project_progress.md (comprehensive update)
- fix_thinking_budget.py (database migration script)
- check_thinking_budget.py (verification script)
🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
2025-12-25 19:44:24 +01:00 |
|
